lib,permission: fix dropping addon permission#64007
Open
mawalu wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
RafaelGSS
approved these changes
Jun 20, 2026
geeksilva97
approved these changes
Jun 24, 2026
Author
|
First time contributing, is there anything I can do to help getting this merged? |
Contributor
we need a successfull ci run. I added the tag. it should start ci soon. |
geeksilva97
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Contributor
|
This PR keeps failing in shared libraries.
@mawalu , could u please rebase this PR with main, just to ensure all deps are good? |
Signed-off-by: Martin <martin@asymmetric.re>
mawalu
force-pushed
the
fix-drop-addons-permission
branch
from
d7036c1 to
5c64b1b
Compare
Author
|
@geeksilva97 just rebased on latest main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading addons currently does not perform a permission check, instead the addon permission was enforced by setting the existing
allow_native_addonsoption.Since
permission.dropdoesn't touch that option,permission.drop('addon')is currently ineffective. Stillpermission.hasreflects the dropped state.This PR fixes this by adding a permission check and introducing the missing test case for the addon permission.